Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance does not work on mobile #176

Closed
LeoIannacone opened this issue Mar 30, 2017 · 7 comments
Closed

Distance does not work on mobile #176

LeoIannacone opened this issue Mar 30, 2017 · 7 comments

Comments

@LeoIannacone
Copy link

LeoIannacone commented Mar 30, 2017

It looks like that it only works if distance is undefined in mobile.

@corneldm
Copy link

corneldm commented Apr 3, 2017

I'm new to this library and can confirm some issues with mobile. distance doesn't cooperate, nor does using SortableHandle in my experience. I'm looking around the source to see if I can help with a PR.

@LeoIannacone was distance working fine with a previous version on mobile? If so, what version?

@LeoIannacone LeoIannacone changed the title Does not work on mobile? Distance does not work on mobile? Apr 3, 2017
@corneldm
Copy link

corneldm commented Apr 3, 2017

My issue with SortableHandle is resolved (I was accidentally building multiple SortableHandle components). distance still seems to be an issue, however.

@LeoIannacone LeoIannacone changed the title Distance does not work on mobile? Distance does not work on mobile Apr 3, 2017
@clauderic
Copy link
Owner

Hey @LeoIannacone, are you using the distance prop in conjunction with the pressDelay prop? If so, you can only use one or the other, not both at the same time

@LeoIannacone
Copy link
Author

This is actually my call:

    const distance = this.context.mobileDetect.phone() ? undefined : 5
    return (
      <ServiceSelectorSorterListSortable
        myData={data}
        onSortEnd={this._onSortEnd.bind(this)}
        distance={distance}
        helperClass='ServiceSelectorSorterItem--sorting'
        />
    )

@alexdemartos
Copy link

Same issues here: distance not working on my Nexus 5, nor Desktop Chrome dev tools mobile-like template. Not using pressDelay.

PD: pressDelay is working fine both on desktop & mobile browsers.

@viniciusvgv
Copy link

The same happens to me, distance doesn't work on touch screens (I have the 0.6.3 version and tested using Chrome's mobile device inspector). pressDelay works just fine but with the layout I have distance feels much better.

@clauderic
Copy link
Owner

Fixed by #378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants