Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pressDelay doesn't trigger close bug #94

Merged
merged 1 commit into from
May 6, 2018
Merged

fix pressDelay doesn't trigger close bug #94

merged 1 commit into from
May 6, 2018

Conversation

ctxhou
Copy link
Owner

@ctxhou ctxhou commented May 6, 2018

This issue is caused from dependency library react-sortable-hoc.

Why need pressDelay?
When a draggable tab with close button, user clicks on close button will not trigger click action. Because the container of the button is wrapped by react-sortable-hoc and this lib will treat this click as dnd action then block the downward.
Therefore, to solve this issue is set the pressDelay props. It means if user clicks on the tab more than xx millisecond, trigger dnd or keep original action flow.

Why not use distance props?
Based on this issue, distance props is not working on mobile device.
Thus, pressDelay would be better solution.

fix #92.

@codecov-io
Copy link

codecov-io commented May 6, 2018

Codecov Report

Merging #94 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   85.53%   85.53%           
=======================================
  Files          20       20           
  Lines         318      318           
  Branches       59       59           
=======================================
  Hits          272      272           
  Misses         37       37           
  Partials        9        9
Impacted Files Coverage Δ
src/TabModal.js 50% <ø> (ø) ⬆️
src/DragTabList.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c8d9a...90656e0. Read the comment docs.

@ctxhou ctxhou merged commit 82c2249 into master May 6, 2018
ctxhou added a commit that referenced this pull request May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

closable not working when ExtraButton is set
2 participants