fix pressDelay doesn't trigger close bug #94
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is caused from dependency library
react-sortable-hoc
.Why need pressDelay?
When a draggable tab with
close button
, user clicks on close button will not trigger click action. Because the container of the button is wrapped byreact-sortable-hoc
and this lib will treat this click as dnd action then block the downward.Therefore, to solve this issue is set the
pressDelay
props. It means if user clicks on the tab more thanxx millisecond
, trigger dnd or keep original action flow.Why not use distance props?
Based on this issue, distance props is not working on mobile device.
Thus,
pressDelay
would be better solution.fix #92.