Fix drag when scrolling #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clauderic
approved these changes
Jul 2, 2017
There was a problem hiding this comment.
Hey @AlastairTaft, just tested this and it seems to work well! Code looks good also 👍
Thanks for taking the time to submit this PR :)
DimitarNestorov
pushed a commit
to codemotionapps/react-sortable-hoc
that referenced
this pull request
Feb 4, 2019
Fix drag when scrolling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests updates the code to account for window scroll position. At the moment if the user scrolls the page while they are dragging an item, all the calculations are incorrect and you see the drag item jump position equivalent to how far you've scrolled.
This makes adjustments to account for the window scroll position.