Set contentWindow default ourselves to avoid Jest serialization #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jest serializes all props in snapshots. Window is a huge object, so when Jest tries to serialize it, it typically throws `RangeError: Invalid string length` because the process runs out of memory. This switches from using defaultProps to setting the default ourselves, so in the test environment there won't be a prop value to serialize.
|
Just published this fix with |
|
❤️ Thanks, this component has saved me much time. I'm happy to have contributed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #249
Jest serializes all props in snapshots. The current code sets window by default, which is a huge object. When Jest tries to serialize it, it typically throws
RangeError: Invalid string lengthbecause the process runs out of memory. If you're lucky enough to actually get a test to pass, the snapshot will be around 250mb.This switches from using defaultProps to setting the default ourselves, so in the test environment there won't be a prop value to serialize.
I confirmed the commonjs version fixes the issue. I'm not sure how to test the es6/umd versions.
npm testpasses.