Fix a bug when you use SortableHandle and distance prop. #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redking
added a commit
to DataDog/react-sortable-hoc
that referenced
this pull request
Nov 23, 2018
|
Just shipped |
kiejo
pushed a commit
to Nuclino/react-sortable-hoc
that referenced
this pull request
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue when you set a distance and you use
SortableHandle.After you click on the handle, you are able to drag the element from everywhere inside the
li.So the main problem comes from here. During the handleStart we set the manager.
But inside the
handleEndwe never unset the manager if the distance prop was set. You can check the code here. It's true that we shouldn't callclearTimeout(this.pressTimer);when you had set a distance because you can't set both properties (distance | pressDelay).Feel free to ask me for changes if you find a better approach ✌️