sql/schemachanger: avoid retries on invalid expressions during backfills #142490
+29
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Currently, the schema changer uses a white list to determine which errors to be retired, which in some cases use a text comparison. Unfortunately, when we parse expressions their text can appear in the error and cause errors to be erroneously retried for backfills. To address this, this patch explicitly wraps errors from eval.Expr with SchemaChangerUserError to block retries. Fixes: cockroachdb#141352 Release note (bug fix): Invalid default expressions could cause backfilling schema changes to retry forever
fqazi
force-pushed
the
createIndexParseErrorFix
branch
from
418bf6b to
b5c6d29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the schema changer uses a white list to determine which errors to be retired, which in some cases use a text comparison. Unfortunately, when we parse expressions their text can appear in the error and cause errors to be erroneously retried for backfills. To address this, this patch explicitly wraps errors from eval.Expr with SchemaChangerUserError to block retries.
Fixes: #141352
Release note (bug fix): Invalid default expressions could cause backfilling schema changes to retry forever