kvserver: never mark replicas as unreachable in TestFlowControl.* #142498
+71
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
kvoli
force-pushed
the
250307.rac-mark-unreachable-test-flow-control
branch
from
dffcf92 to
e3c5710
Compare
The `TestFlowControl.*` tests don't expect replicas to blip in and out of `StateProbe` as a result of the testing environment or timing conditions. Prohibit this via setting `RaftReportUnreachableBypass`. Fixes: cockroachdb#142413 Fixes: cockroachdb#142442 Fixes: cockroachdb#142450 Fixes: cockroachdb#142465 Fixes: cockroachdb#142464 Fixes: cockroachdb#142463 Fixes: cockroachdb#142462 Fixes: cockroachdb#142451 Release note: None
kvoli
force-pushed
the
250307.rac-mark-unreachable-test-flow-control
branch
from
e3c5710 to
cf225dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TestFlowControl.*tests don't expect replicas to blip in and outof
StateProbeas a result of the testing environment or timingconditions. Prohibit this via setting
RaftReportUnreachableBypass.Fixes: #142413
Fixes: #142442
Fixes: #142450
Fixes: #142465
Fixes: #142464
Fixes: #142463
Fixes: #142462
Fixes: #142451
Release note: None