chore: Remove barrel services/navigation #3761

nicholas-codecov · 2025-02-21T13:59:12Z

Description

This PR removes the barrel files from services/navigation directory, tidy up the services/navigation directory, update imports and test mocks across the app.

Ticket: codecov/engineering-team#3352

Notable Changes

Remove barrel files from services/navigation
Update imports and tests

codecov · 2025-02-21T14:01:27Z

Bundle Report

Changes will increase total bundle size by 18 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-system	6.14MB	12 bytes (0.0%) ⬆️
gazebo-production-esm	6.2MB	6 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index.*.js`	6 bytes	629.59kB	0.0%

Files in assets/index.*.js:

./src/pages/OwnerPage/OnboardingContainerContext/context.tsx → Total Size: 1.79kB
./src/App.tsx → Total Size: 8.54kB
./src/pages/AdminSettings/AdminMembers/MemberList/MemberTable.tsx → Total Size: 6.68kB
./src/pages/AdminSettings/AdminMembers/MemberList/MemberList.jsx → Total Size: 3.01kB
./src/layouts/BaseLayout/hooks/useUserAccessGate.js → Total Size: 2.91kB

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-legacy.*.js`	15 bytes	709.23kB	0.0%
`assets/vendor_recharts-legacy.*.js`	-3 bytes	523.54kB	-0.0%

Files in assets/index-legacy.*.js:

./src/pages/OwnerPage/OnboardingContainerContext/context.tsx → Total Size: 1.79kB
./src/layouts/BaseLayout/hooks/useUserAccessGate.js → Total Size: 2.91kB
./src/App.tsx → Total Size: 8.7kB
./src/pages/AdminSettings/AdminMembers/MemberList/MemberList.jsx → Total Size: 3.01kB
./src/pages/AdminSettings/AdminMembers/MemberList/MemberTable.tsx → Total Size: 6.68kB

codecov · 2025-02-21T14:01:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (9e10243) to head (029d54f).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3761   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files         825      825           
  Lines       14842    14842           
  Branches     4252     4252           
=======================================
  Hits        14646    14646           
  Misses        189      189           
  Partials        7        7

Files with missing lines	Coverage Δ
src/App.tsx	`100.00% <ø> (ø)`
src/layouts/BaseLayout/hooks/useUserAccessGate.js	`100.00% <ø> (ø)`
...tabs/Admin/ManageAdminCard/AddAdmins/AddAdmins.jsx	`100.00% <ø> (ø)`
...ngs/tabs/Admin/ManageAdminCard/ManageAdminCard.jsx	`100.00% <ø> (ø)`
...minSettings/AdminMembers/MemberList/MemberList.jsx	`94.11% <ø> (ø)`
...inSettings/AdminMembers/MemberList/MemberTable.tsx	`100.00% <ø> (ø)`
src/pages/AnalyticsPage/AnalyticsPage.jsx	`100.00% <ø> (ø)`
...mitDetailFileExplorer/CommitDetailFileExplorer.tsx	`100.00% <ø> (ø)`
...e/routes/ComponentsSelector/ComponentsSelector.tsx	`100.00% <ø> (ø)`
...hangedTab/shared/CommitFileDiff/CommitFileDiff.tsx	`97.56% <ø> (ø)`
... and 57 more

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.69% <ø> (ø)`
Pages	`98.26% <ø> (ø)`
Services	`99.24% <ø> (ø)`
Shared	`99.11% <ø> (ø)`
UI	`99.07% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e10243...029d54f. Read the comment docs.

codecov-staging · 2025-02-21T14:01:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3761   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files         825      825           
  Lines       14842    14842           
  Branches     4244     4244           
=======================================
  Hits        14646    14646           
  Misses        189      189           
  Partials        7        7

Files with missing lines	Coverage Δ
src/App.tsx	`100.00% <ø> (ø)`
src/layouts/BaseLayout/hooks/useUserAccessGate.js	`100.00% <ø> (ø)`
...tabs/Admin/ManageAdminCard/AddAdmins/AddAdmins.jsx	`100.00% <ø> (ø)`
...ngs/tabs/Admin/ManageAdminCard/ManageAdminCard.jsx	`100.00% <ø> (ø)`
...minSettings/AdminMembers/MemberList/MemberList.jsx	`94.11% <ø> (ø)`
...inSettings/AdminMembers/MemberList/MemberTable.tsx	`100.00% <ø> (ø)`
src/pages/AnalyticsPage/AnalyticsPage.jsx	`100.00% <ø> (ø)`
...mitDetailFileExplorer/CommitDetailFileExplorer.tsx	`100.00% <ø> (ø)`
...e/routes/ComponentsSelector/ComponentsSelector.tsx	`100.00% <ø> (ø)`
...hangedTab/shared/CommitFileDiff/CommitFileDiff.tsx	`97.56% <ø> (ø)`
... and 57 more

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.69% <ø> (ø)`
Pages	`98.26% <ø> (ø)`
Services	`99.24% <ø> (ø)`
Shared	`99.11% <ø> (ø)`
UI	`99.07% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e10243...029d54f. Read the comment docs.

codecov-qa · 2025-02-21T14:01:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (9e10243) to head (029d54f).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3761   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files         825      825           
  Lines       14842    14842           
  Branches     4252     4244    -8     
=======================================
  Hits        14646    14646           
  Misses        189      189           
  Partials        7        7

Files with missing lines	Coverage Δ
src/App.tsx	`100.00% <ø> (ø)`
src/layouts/BaseLayout/hooks/useUserAccessGate.js	`100.00% <ø> (ø)`
...tabs/Admin/ManageAdminCard/AddAdmins/AddAdmins.jsx	`100.00% <ø> (ø)`
...ngs/tabs/Admin/ManageAdminCard/ManageAdminCard.jsx	`100.00% <ø> (ø)`
...minSettings/AdminMembers/MemberList/MemberList.jsx	`94.11% <ø> (ø)`
...inSettings/AdminMembers/MemberList/MemberTable.tsx	`100.00% <ø> (ø)`
src/pages/AnalyticsPage/AnalyticsPage.jsx	`100.00% <ø> (ø)`
...mitDetailFileExplorer/CommitDetailFileExplorer.tsx	`100.00% <ø> (ø)`
...e/routes/ComponentsSelector/ComponentsSelector.tsx	`100.00% <ø> (ø)`
...hangedTab/shared/CommitFileDiff/CommitFileDiff.tsx	`97.56% <ø> (ø)`
... and 57 more

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.69% <ø> (ø)`
Pages	`98.26% <ø> (ø)`
Services	`99.24% <ø> (ø)`
Shared	`99.11% <ø> (ø)`
UI	`99.07% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e10243...029d54f. Read the comment docs.

codecov-public-qa · 2025-02-21T14:01:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (9e10243) to head (029d54f).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3761   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files         825      825           
  Lines       14842    14842           
  Branches     4252     4244    -8     
=======================================
  Hits        14646    14646           
  Misses        189      189           
  Partials        7        7

Files with missing lines	Coverage Δ
src/App.tsx	`100.00% <ø> (ø)`
src/layouts/BaseLayout/hooks/useUserAccessGate.js	`100.00% <ø> (ø)`
...tabs/Admin/ManageAdminCard/AddAdmins/AddAdmins.jsx	`100.00% <ø> (ø)`
...ngs/tabs/Admin/ManageAdminCard/ManageAdminCard.jsx	`100.00% <ø> (ø)`
...minSettings/AdminMembers/MemberList/MemberList.jsx	`94.11% <ø> (ø)`
...inSettings/AdminMembers/MemberList/MemberTable.tsx	`100.00% <ø> (ø)`
src/pages/AnalyticsPage/AnalyticsPage.jsx	`100.00% <ø> (ø)`
...mitDetailFileExplorer/CommitDetailFileExplorer.tsx	`100.00% <ø> (ø)`
...e/routes/ComponentsSelector/ComponentsSelector.tsx	`100.00% <ø> (ø)`
...hangedTab/shared/CommitFileDiff/CommitFileDiff.tsx	`97.56% <ø> (ø)`
... and 57 more

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.69% <ø> (ø)`
Pages	`98.26% <ø> (ø)`
Services	`99.24% <ø> (ø)`
Shared	`99.11% <ø> (ø)`
UI	`99.07% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e10243...029d54f. Read the comment docs.

codecov-staging · 2025-02-21T14:01:59Z

Bundle Report

Changes will increase total bundle size by 18 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-system	6.14MB	12 bytes (0.0%) ⬆️
gazebo-staging-esm	6.2MB	6 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index.*.js`	6 bytes	629.59kB	0.0%

Files in assets/index.*.js:

./src/pages/OwnerPage/OnboardingContainerContext/context.tsx → Total Size: 1.79kB
./src/pages/AdminSettings/AdminMembers/MemberList/MemberTable.tsx → Total Size: 6.68kB
./src/pages/AdminSettings/AdminMembers/MemberList/MemberList.jsx → Total Size: 3.01kB
./src/App.tsx → Total Size: 8.54kB
./src/layouts/BaseLayout/hooks/useUserAccessGate.js → Total Size: 2.91kB

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-legacy.*.js`	15 bytes	709.23kB	0.0%
`assets/vendor_recharts-legacy.*.js`	-3 bytes	523.54kB	-0.0%

Files in assets/index-legacy.*.js:

./src/App.tsx → Total Size: 8.7kB
./src/pages/AdminSettings/AdminMembers/MemberList/MemberTable.tsx → Total Size: 6.68kB
./src/layouts/BaseLayout/hooks/useUserAccessGate.js → Total Size: 2.91kB
./src/pages/OwnerPage/OnboardingContainerContext/context.tsx → Total Size: 1.79kB
./src/pages/AdminSettings/AdminMembers/MemberList/MemberList.jsx → Total Size: 3.01kB

codecov-releaser · 2025-02-21T14:04:53Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`4f3a73c`	Fri, 21 Feb 2025 14:04:53 GMT	Expired	Expired
`c9fa9ed`	Fri, 21 Feb 2025 14:16:30 GMT	Expired	Expired
`c9fa9ed`	Fri, 21 Feb 2025 14:21:36 GMT	Expired	Expired
`029d54f`	Fri, 21 Feb 2025 16:03:12 GMT	Cloud	Enterprise

spalmurray-codecov approved these changes Feb 21, 2025

View reviewed changes

nicholas-codecov added 4 commits February 21, 2025 11:57

remove barrel file and move files around to tidy up directory

f7223a5

update imports and tests

fb54ad2

fix up failing tests

5191ca8

more test fixes

029d54f

nicholas-codecov force-pushed the gh-eng-3352-remove-barrel-services-navigation branch from c9fa9ed to 029d54f Compare February 21, 2025 15:58

nicholas-codecov added this pull request to the merge queue Feb 24, 2025

Merged via the queue into main with commit 265e068 Feb 24, 2025
62 checks passed

nicholas-codecov deleted the gh-eng-3352-remove-barrel-services-navigation branch February 24, 2025 12:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Remove barrel services/navigation #3761

chore: Remove barrel services/navigation #3761

nicholas-codecov commented Feb 21, 2025

codecov bot commented Feb 21, 2025 •

edited

Loading

Assets Changed:

Assets Changed:

codecov bot commented Feb 21, 2025 •

edited

Loading

codecov-staging bot commented Feb 21, 2025 •

edited by codecov-notifications bot

Loading

codecov-qa bot commented Feb 21, 2025 •

edited

Loading

codecov-public-qa bot commented Feb 21, 2025 •

edited

Loading

codecov-staging bot commented Feb 21, 2025 •

edited

Loading

Assets Changed:

Assets Changed:

codecov-releaser commented Feb 21, 2025 •

edited

Loading

chore: Remove barrel services/navigation #3761

chore: Remove barrel services/navigation #3761

Conversation

nicholas-codecov commented Feb 21, 2025

Description

Notable Changes

codecov bot commented Feb 21, 2025 • edited Loading

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Assets Changed:

codecov bot commented Feb 21, 2025 • edited Loading

Codecov Report

codecov-staging bot commented Feb 21, 2025 • edited by codecov-notifications bot Loading

Codecov Report

codecov-qa bot commented Feb 21, 2025 • edited Loading

Codecov Report

codecov-public-qa bot commented Feb 21, 2025 • edited Loading

Codecov Report

codecov-staging bot commented Feb 21, 2025 • edited Loading

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Assets Changed:

codecov-releaser commented Feb 21, 2025 • edited Loading

✅ Deploy preview for gazebo ready!

codecov bot commented Feb 21, 2025 •

edited

Loading

codecov bot commented Feb 21, 2025 •

edited

Loading

codecov-staging bot commented Feb 21, 2025 •

edited by codecov-notifications bot

Loading

codecov-qa bot commented Feb 21, 2025 •

edited

Loading

codecov-public-qa bot commented Feb 21, 2025 •

edited

Loading

codecov-staging bot commented Feb 21, 2025 •

edited

Loading

codecov-releaser commented Feb 21, 2025 •

edited

Loading