Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try a non-regex parser #225

Closed
epage opened this issue Apr 18, 2021 · 0 comments · Fixed by #235
Closed

Try a non-regex parser #225

epage opened this issue Apr 18, 2021 · 0 comments · Fixed by #235

Comments

@epage
Copy link
Collaborator

epage commented Apr 18, 2021 •
edited
Loading

While none of the comparisons in #224 are apples to apples, it does make me suspect that the regex parser is quite expensive. It'd be interesting to try out a more specialized parser, like one written in Nom
epage pushed a commit to epage/typos that referenced this issue Apr 30, 2021
fix(parser)!: Defer to Unicode XID for identifiers
9cbc741 
This saves us from having to have configuration for every detail.  If
people need more control, we can offer it later.

Fixes crate-ci#225
@epage epage mentioned this issue Apr 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(parser): Overhaul how parsing is done epage/typos
1 participant
@epage