Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't correct common names #249

Open
epage opened this issue May 15, 2021 · 1 comment
Open

Don't correct common names #249

epage opened this issue May 15, 2021 · 1 comment
Labels
A-dict C-bug Category: bug S-waiting-on-decision Status: Waiting on a go/no-go before implementing

Comments

@epage
Copy link
Collaborator

epage commented May 15, 2021

For example, the Linux kernel has a contributor with the last name "Teh" but that gets corrected to "The".
@epage epage added the C-bug Category: bug label May 15, 2021
epage pushed a commit to epage/typos that referenced this issue May 18, 2021
fix(dict): Handle cases from Linux
09819c1 
These were found while running `typos` on Linux and inspecting a
sampling of the results.  crate-ci#249 represents additional changes to make.
There were some identifiers, that looked like hardware registers, that
I'm unsure of what can be done for them.
@epage epage mentioned this issue May 18, 2021
Merged
epage pushed a commit to epage/typos that referenced this issue May 18, 2021
fix(dict): Handle cases from Linux
5e99b6f 
These were found while running `typos` on Linux and inspecting a
sampling of the results.  crate-ci#249 represents additional changes to make.
There were some identifiers, that looked like hardware registers, that
I'm unsure of what can be done for them.
epage pushed a commit to epage/typos that referenced this issue May 18, 2021
fix(dict): Handle cases from Linux
639e65b 
These were found while running `typos` on Linux and inspecting a
sampling of the results.  crate-ci#249 represents additional changes to make.
There were some identifiers, that looked like hardware registers, that
I'm unsure of what can be done for them.
@epage
Copy link
Collaborator Author

epage commented May 18, 2021

We could scour https://en.wikipedia.org/wiki/Lists_of_most_common_surnames

I also found https://github.com/smashew/NameDatabases/tree/master/NamesDatabases

@epage epage added A-dict S-triage Status: New; needs maintainer attention. S-waiting-on-decision Status: Waiting on a go/no-go before implementing and removed S-triage Status: New; needs maintainer attention. labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dict C-bug Category: bug S-waiting-on-decision Status: Waiting on a go/no-go before implementing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epage