-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(infra): Publish Docker image on release #1183
base: master
Are you sure you want to change the base?
Conversation
The post-release job will trigger publish-docker-image job which builds and pushes the image to the GitHub Container Registry (ghcr.io). The image is tagged with the semver tag and latest. Signed-off-by: Alex Apostolescu <[email protected]>
At my quick glance, this seems very different than the workflow from #1116. As the person purposing this alternative workflow, could you step through why you made different decisions? |
Hello, @epage, thanks for taking the time to review! My PR only addresses building the docker image on release to be able to run the action locally similarly to how it is run on GH actions pipeline. I have no interest in updating the Dockerfile. Therefore, you could say that the PRs are complementary; in my view, changes on Dockerfile should be separated from changes on actions. The backbone for my changes is this guide from GitHub. Let's dive into my changes:
|
Hi, @epage! Bump on this. |
Please don't bump. I have a queue I'm working through, made worse from the holidays, and this creates extra noise. |
Hi, @epage, I respect that you have a list and requested not to be bumped on updates. The PR remained stable and requires minimal feedback to go forward and add an essential feature.
Again, I respect your schedule and am eager to help you with information to merge this. |
That is very rude to re-bump a PR when you've already been told not to bump it. |
The post-release job will trigger the publish-docker-image job which builds and pushes the image to the GitHub Container Registry (ghcr.io). The image is tagged with the
semver tag
andlatest
.Regarding #427 (comment), even a focused image can be helpful for local development and testing. I think it would be beneficial to start publishing the image even if it might change in the future.
I tested these changes on my fork:
publish-docker-image
actionFixes: #427