Do not correct seeked word #1231
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
reviewed
Feb 13, 2025
| @@ -3477,7 +3477,6 @@ seceeded->succeeded, seceded | |||
| secratary->secretary | |||
| secretery->secretary | |||
| sedereal->sidereal | |||
| seeked->sought | |||
There was a problem hiding this comment.
This should be reverted. We only use typos-dict. The others are for comparison purposes
|
Per the instructions in #1221 and our contributing guide, could you open an issue first? We focus Issues on getting consesus on problems and solutions and PRs for implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The word seeked is used for simplicity in the web api and when you work a lot with different video and media related project on the web it becomes really annoying that typos is always referring this in every project (and actually throws an error even when you open lib.dom.ts the typescript bindings to web api).
I tried to check your misspelled implementation but it looks it using some totally abandoned project https://github.com/client9/misspell so I decided to just exclude it in the most naive way. Please let me know if something lese needs to be done