Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade cargo, cargo-platform dependencies to support the 2024 edition. #806

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eric-seppanen
Copy link

Without this change, cargo crev verify always prints:

failed to load manifest for workspace member `.../crates/some_crate`
referenced by workspace at `.../my_workspace/Cargo.toml`

Caused by:
    0: failed to parse manifest at `.../crates/Cargo.toml`
    1: feature `edition2024` is required
       
       The package requires the Cargo feature called `edition2024`, but that feature is not stabilized in this version of Cargo (1.84.0).
       Consider adding `cargo-features = ["edition2024"]` to the top of Cargo.toml (above the [package] table) to tell Cargo you are opting in to use this unstable feature.
       See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#edition-2024 for more information about the status of this feature.

Checklist:

  • cargo +nightly fmt --all

I did not do this as it changes the formatting of existing code, unrelated to this PR which does not change any .rs files. Maybe formatting should be checked in CI instead?

  • Modify CHANGELOG.md if applicable

This allows support for the rust 2024 edition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant