Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add switch to make it possible to disable crds in helmfiles #610

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

joschi36
Copy link
Contributor

Adding the same behaviour as in #563 for helmfile

@Joibel
Copy link
Contributor

Joibel commented Oct 31, 2024

#269 means CI won't work completely, so don't worry about that.

@joschi36
Copy link
Contributor Author

Thanks for your prompt update. Unfortunately, I can't build or test the code right now. I only eyeballed it and hoped your workflow will create a container that I can test tomorrow on my environment 😅

@Joibel
Copy link
Contributor

Joibel commented Oct 31, 2024

Thanks for your prompt update. Unfortunately, I can't build or test the code right now. I only eyeballed it and hoped your workflow will create a container that I can test tomorrow on my environment 😅

#269 unfortunately prevents the images being made.

I've manually built you joibel/argocd-lovely-plugin:pr610. This is a versioned plugin, with the version being pr610. amd64 only.

@joschi36
Copy link
Contributor Author

joschi36 commented Nov 1, 2024

Hi @Joibel, I just tested the image and it seems to work just fine. With and without parameters.

Thank you very much for your help 👍

Please advise if I need to make changes.

Copy link
Contributor

@Joibel Joibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, looks good.

@Joibel Joibel merged commit 2d723f0 into crumbhole:main Nov 1, 2024
11 of 12 checks passed
@joschi36 joschi36 deleted the patch-1 branch November 1, 2024 14:01
@Joibel
Copy link
Contributor

Joibel commented Nov 25, 2024

I am releasing 1.2.0 with this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants