Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect from prefix root to status #9015

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

icykip
Copy link

@icykip icykip commented Feb 21, 2025

Closes #9014

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Contributor

github-actions bot commented Feb 21, 2025

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    26 files  ±  0      26 suites  ±0   11h 9m 47s ⏱️ - 6m 8s
 4 101 tests +  1   3 983 ✅  -   2    112 💤 +  1  6 ❌ +3 
50 007 runs  +793  47 764 ✅ +669  2 237 💤 +122  6 ❌ +3 

For more details on these failures, see this check.

Results for commit e229d54. ± Comparison against base commit fe5e431.

This pull request skips 1 test.
distributed.tests.test_client ‑ test_computation_object_code_not_available

♻️ This comment has been updated with latest results.

@icykip
Copy link
Author

icykip commented Feb 24, 2025

Failing tests seem to be due to an unexpected key type in this test: distributed\http\scheduler\tests\test_scheduler_http.py

Haven't been able to recreate this locally and haven't been able to find a link between the failures and my changes, any help would be appreciated!

@jacobtomlinson
Copy link
Member

CI failures look related to #9016. I'll get a fix in and then we can rerun things here.

@jacobtomlinson
Copy link
Member

I've merged main in here so CI should now behave more normally.

@icykip
Copy link
Author

icykip commented Feb 28, 2025

Thanks for the fix! Sorry for taking a while to get back to this, took a look at the tests that are still failing and although there seems to be a wider array of reasons, I'm struggling to see how these are connected to my changes. Any advice would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard does not redirect to status from prefix root.
2 participants