Do not wait for app compute to start on bundle deploy
#2144
+13
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
requested review from
pietern,
shreyas-goenka and
denik
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
approved these changes
Jan 14, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
## Changes When users create one or more Databricks apps in their bundle it can lead to initial bundle deployment being slower because apps need to wait until their compute is fully provisioned and started. This PR adds a message to warn about it. This message will be removed when `no_compute` option becomes available in TF provider and used in DABs (#2144)
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
changed the title
bundle deploy
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
added a commit
that referenced
this pull request
Jan 29, 2025
Bundles: * Added support for double underscore variable references ([#2203](#2203)). * Do not wait for app compute to start on `bundle deploy` ([#2144](#2144)). * Remove bundle.git.inferred ([#2258](#2258)). * libs/python: Remove DetectInterpreters ([#2234](#2234)). API Changes: * Added `databricks access-control` command group. * Added `databricks serving-endpoints http-request` command. * Changed `databricks serving-endpoints create` command with new required argument order. * Changed `databricks serving-endpoints get-open-api` command return type to become non-empty. * Changed `databricks recipients update` command return type to become non-empty. OpenAPI commit 0be1b914249781b5e903b7676fd02255755bc851 (2025-01-22) Dependency updates: * Bump github.com/databricks/databricks-sdk-go from 0.55.0 to 0.56.1 ([#2238](#2238)). * Upgrade TF provider to 1.64.1 ([#2247](#2247)).
andrewnester
added a commit
that referenced
this pull request
Jan 29, 2025
Bundles: * Added support for double underscore variable references ([#2203](#2203)). * Do not wait for app compute to start on `bundle deploy` ([#2144](#2144)). * Remove bundle.git.inferred ([#2258](#2258)). * libs/python: Remove DetectInterpreters ([#2234](#2234)). API Changes: * Added `databricks access-control` command group. * Added `databricks serving-endpoints http-request` command. * Changed `databricks serving-endpoints create` command with new required argument order. * Changed `databricks serving-endpoints get-open-api` command return type to become non-empty. * Changed `databricks recipients update` command return type to become non-empty. OpenAPI commit 0be1b914249781b5e903b7676fd02255755bc851 (2025-01-22) Dependency updates: * Bump github.com/databricks/databricks-sdk-go from 0.55.0 to 0.56.1 ([#2238](#2238)). * Upgrade TF provider to 1.64.1 ([#2247](#2247)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This allows DABs to avoid waiting for the compute to start when app is initially created as part of "bundle deploy" which significantly improves deploy time.
Always set no_compute to true for apps
Tests
Covered by
TestDeployBundleWithApp, currently fails until TF provider is upgraded to the version supportingno_computeoption