Use tar.gz for Mac and Linux #2351
Open
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes
-------
Changes GitHub releases to handle Mac and Linux binaries slightly differently than Windows.
| Operating System | Archive Format |
| ---------------- | -------------- |
| Mac OS | `tar.gz` |
| Linux | `tar.gz` |
| Windows | `zip` |
Tests
-----
I tested with the following commands.
```bash
$ goreleaser release --snapshot
$ ls -1 dist/*.{zip,tar.gz}
dist/databricks_cli_darwin_amd64.tar.gz
dist/databricks_cli_darwin_arm64.tar.gz
dist/databricks_cli_linux_amd64.tar.gz
dist/databricks_cli_linux_arm64.tar.gz
dist/databricks_cli_windows_amd64.zip
dist/databricks_cli_windows_arm64.zip
```
Related issues
--------------
Closes databricks#1296
Co-authored-by: Sam Gleske <[email protected]>
samrocketman
requested review from
pietern,
andrewnester,
shreyas-goenka and
denik
as code owners
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
Thanks for the PR. We can't accept this as is because changing the archive format is a breaking change for automation. We'll consider adding |
|
@pietern goreleases supports shipping multiple archive formats so I can add overrides for Mac and Linux to provide both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changes GitHub releases to handle Mac and Linux binaries slightly differently than Windows.
tar.gztar.gzzipTests
I tested with the following commands.
$ goreleaser release --snapshot $ ls -1 dist/*.{zip,tar.gz} dist/databricks_cli_darwin_amd64.tar.gz dist/databricks_cli_darwin_arm64.tar.gz dist/databricks_cli_linux_amd64.tar.gz dist/databricks_cli_linux_arm64.tar.gz dist/databricks_cli_windows_amd64.zip dist/databricks_cli_windows_arm64.zipRelated issues
Closes #1296