Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display username while removing the user from the group #11706

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Display username while removing the user from the group #11706

merged 2 commits into from
Nov 20, 2024

Conversation

kanavnarula
Copy link
Contributor

@kanavnarula kanavnarula commented Oct 24, 2024 •
edited
Loading

This change is to display username (for the confirmation) while removing the user from the group.

Before:
image

After:
image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Oct 24, 2024
@kanavnarula kanavnarula mentioned this pull request Oct 24, 2024
Closed
5 tasks
@kanavnarula
Copy link
Contributor Author

@jjoyce0510 @david-leifker - Can you please review this minor PR when you get chance.

@kanavnarula
Copy link
Contributor Author

@jjoyce0510 @david-leifker - Can you please review this PR and merge when get chance

@jjoyce0510 jjoyce0510 merged commit 218c059 into datahub-project:master Nov 20, 2024
40 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@kanavnarula @sleeperdeep
feat(ui): Display username while removing the user from the group (da…
d1bf08e 
…tahub-project#11706)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanavnarula @jjoyce0510