Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingestion/powerbi): handle double quotes in M-query #11743

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix(ingestion/powerbi): handle double quotes in M-query #11743

merged 1 commit into from
Oct 30, 2024

Conversation

sid-acryl
Copy link
Contributor

  1. M-Query which contains SQL: 
        select 
         order_number AS ""OrderNumber""
     from DM_OPERATIONS.VI
    was not working because of two double quotes after AS. This PR will fix this issue.

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 29, 2024
hsheth2
hsheth2 approved these changes Oct 30, 2024
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/powerbi/powerbi-lexical-grammar.rule
@@ -340,8 +346,12 @@ not_implemented_expression: "..."

invoke_expression: "#"? primary_expression "(" NEWLINE? argument_list? NEWLINE? ")"

SQL_STRING: /\"((?:[^\"\\]|\\[\"]|\"\"|\#\(lf\))+)\"/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did this regex come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

claude.ai

@hsheth2 hsheth2 merged commit 0e62c69 into datahub-project:master Oct 30, 2024
75 of 77 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@sid-acryl @sleeperdeep
fix(ingestion/powerbi): handle double quotes in M-query (datahub-proj…
568942c 
…ect#11743)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sid-acryl @hsheth2