-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ui): Migrate to use the new Button component consistently #12597
Merged
jjoyce0510
merged 12 commits into
datahub-project:master
from
jjoyce0510:jj--ux-fixes-button-replacement
Feb 27, 2025
Merged
refactor(ui): Migrate to use the new Button component consistently #12597
jjoyce0510
merged 12 commits into
datahub-project:master
from
jjoyce0510:jj--ux-fixes-button-replacement
Feb 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
436a9e3
to
56eb99a
Compare
Buttons checkpoint Adding more linting Migrate to using the new button Committing changes
chriscollins3456
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving with one comment i think needs a look before merging - thank you for this!
datahub-web-react/src/app/entityV2/shared/tabs/Documentation/DocumentationTab.tsx
Outdated
Show resolved
Hide resolved
0235e40
to
1f732d9
Compare
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Mar 3, 2025
…atahub-project#12597) Co-authored-by: John Joyce <[email protected]> Co-authored-by: John Joyce <[email protected]> Co-authored-by: John Joyce <[email protected]> Co-authored-by: John Joyce <[email protected]> Co-authored-by: John Joyce <[email protected]> Co-authored-by: John Joyce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR, we migrate to using the standard Button component across all major surface areas of the application.
There are also a few minor copy changes, nothing particularly impactful. Please do a sanity check, but the behaviors should not be impacted by migrating these buttons.
Checklist