Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): Migrate to use the new Button component consistently #12597

Merged

Conversation

jjoyce0510
Copy link
Collaborator

Summary

In this PR, we migrate to using the standard Button component across all major surface areas of the application.
There are also a few minor copy changes, nothing particularly impactful. Please do a sanity check, but the behaviors should not be impacted by migrating these buttons.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Feb 11, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 11, 2025
@jjoyce0510 jjoyce0510 force-pushed the jj--ux-fixes-button-replacement branch from 436a9e3 to 56eb99a Compare February 11, 2025 18:23
Buttons checkpoint

Adding more linting

Migrate to using the new button

Committing changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with one comment i think needs a look before merging - thank you for this!

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Feb 11, 2025
@jjoyce0510 jjoyce0510 force-pushed the jj--ux-fixes-button-replacement branch from 0235e40 to 1f732d9 Compare February 11, 2025 23:47
@jjoyce0510 jjoyce0510 merged commit 8dd2f6e into datahub-project:master Feb 27, 2025
46 of 47 checks passed
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 3, 2025
…atahub-project#12597)

Co-authored-by: John Joyce <[email protected]>
Co-authored-by: John Joyce <[email protected]>
Co-authored-by: John Joyce <[email protected]>
Co-authored-by: John Joyce <[email protected]>
Co-authored-by: John Joyce <[email protected]>
Co-authored-by: John Joyce <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants