Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed unnecessary base-line-height #3873

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nmerget
Copy link
Collaborator

@nmerget nmerget commented Feb 27, 2025

Proposed changes

We used base-font-size/-line-height with a calc(var(--db-base-font-size) * var(--db-base-line-height)) function for some components.
But we don't need it, it's the same like the already calculated --db-icon-font-size

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget requested a review from mfranzke as a code owner February 27, 2025 15:57
@nmerget nmerget enabled auto-merge (squash) February 27, 2025 15:57
@github-actions github-actions bot added 🏗foundations Changes inside foundations folder 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Feb 27, 2025
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏘components Changes inside components folder 🏗foundations Changes inside foundations folder 📺showcases Changes to 1-n showcases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant