Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(upgrade): cache downloaded binaries in DENO_DIR #28297

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

perf(upgrade): cache downloaded binaries in DENO_DIR #28297

wants to merge 8 commits into from
+233 −29

Conversation

littledivy
Copy link
Member

No description provided.

dsherret
dsherret reviewed Feb 26, 2025
View reviewed changes
cli/tools/upgrade.rs

if let Some(bytes) = &maybe_bytes {
fs::create_dir_all(binary_path.parent().unwrap())?;
fs::write(&binary_path, bytes)?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do users get the context about what happened when either of these fail?

bartlomieju
bartlomieju requested changes Feb 26, 2025
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as request changes for myself, as we need to fix tests first to not rely on remote server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret left review comments

@bartlomieju bartlomieju bartlomieju requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@littledivy @dsherret @bartlomieju