refactor: prefer 'if let' to 'match' for single option #28347
Conversation
|
|
danieleades
force-pushed
the
code-quality
branch
from
e58cbbc to
e65f854
Compare
danieleades
force-pushed
the
code-quality
branch
from
e65f854 to
e4a78ac
Compare
danieleades
changed the title
There was a problem hiding this comment.
Sorry, but this creates some churn in the codebase and I don't believe it matters? Feels better to leave it up to the person writing the code whether they'd prefer to use match or if. I also prefer the match in some of the cases. Maybe if there was a lot of indentation, but that doesn't seem to be a problem in most of these cases.
Overall, we'd rather not do style PRs like this on the codebase.
That's an interesting perspective. If that's the position I'll of course respect that. Yes, the main benefit is reducing indentation. I actually think this is a problem in this code base, somewhat masked by the unusual (in rust) 2-space indentation. |
No description provided.