-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create table layout #2343
Comments
Since We (@opencollective) would love to migrate to react-pdf, but we need good support for multi-page tables. We would happily use https://github.com/ag-media/react-pdf-table for that, but I agree that native support for tables in this library would be fantastic. |
@Betree, thanks for the linked repo; it might be the solution we're searching for if we can somehow reconcile react-pdf's layout with the table implementation. I'll take a more in-depth look in a couple of days. |
@mocanew Hello! Are there any updates regarding native table support in react-pdf library? |
The previous way of rendering table was causing issues when tables could not fit on one page. I then came accross this discussion diegomura/react-pdf#2343. The author created a lib to improve the rendering of table, it's better, but still not perfect maybe.
The previous way of rendering table was causing issues when tables could not fit on one page. I then came accross this discussion diegomura/react-pdf#2343. The author created a lib to improve the rendering of table, it's better, but still not perfect maybe.
The previous way of rendering table was causing issues when tables could not fit on one page. I then came accross this discussion diegomura/react-pdf#2343. The author created a lib to improve the rendering of table, it's better, but still not perfect maybe.
The previous way of rendering table was causing issues when tables could not fit on one page. I then came accross this discussion diegomura/react-pdf#2343. The author created a lib to improve the rendering of table, it's better, but still not perfect maybe.
The previous way of rendering table was causing issues when tables could not fit on one page. I then came accross this discussion diegomura/react-pdf#2343. The author created a lib to improve the rendering of table, it's better, but still not perfect maybe.
The previous way of rendering table was causing issues when tables could not fit on one page. I then came accross this discussion diegomura/react-pdf#2343. The author created a lib to improve the rendering of table, it's better, but still not perfect maybe.
The previous way of rendering table was causing issues when tables could not fit on one page. I then came accross this discussion diegomura/react-pdf#2343. The author created a lib to improve the rendering of table, it's better, but still not perfect maybe.
The previous way of rendering table was causing issues when tables could not fit on one page. I then came accross this discussion diegomura/react-pdf#2343. The author created a lib to improve the rendering of table, it's better, but still not perfect maybe.
This lib won't support tables out of the box as we just provide with the primitives. Other libs can and do render tables |
Hi @diegomura ! When you say "other libs can and do render tables", do you have any thoughts / ideas on how we can integrate other libs to accomplish things like this? (and how to integrate such a 3rd party libary)? Just some pointers to what you have in mind would be very helpful |
hi @diegomura, i'm using react-pdf v4 and while import the repo throws error "Invalid border width: undefined" |
Is your feature request related to a problem? Please describe.
I'm the author of @ag-media/react-pdf-table, and after much time wrestling with the layout system, I've concluded that there's no way to implement a proper table layout with the current primitives.
Describe the solution you'd like
The solution is not fully thought through, but I think the most essential parts are:
One alternative might be to add table primitives and have them be special cases in the layout package.
Describe alternatives you've considered
As of now, @ag-media/react-pdf-table is usable for a table that is contained to one page (we use it in production already), but if you want to wrap a table to multiple pages, it gets weird with no way of fixing it.
The text was updated successfully, but these errors were encountered: