-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli/command: remove NotaryClient from CLI interface #5876
Draft
thaJeztah
wants to merge
6
commits into
docker:master
Choose a base branch
from
thaJeztah:less_notary
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+155
−239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5876 +/- ##
==========================================
- Coverage 59.32% 59.27% -0.05%
==========================================
Files 353 353
Lines 29748 29791 +43
==========================================
+ Hits 17647 17659 +12
- Misses 11113 11145 +32
+ Partials 988 987 -1 |
This uuid package was introduced in 89db01e, but we want to reduce dependency on the old docker/distribution module. Replace it with google/uuid, which is a commonly used module for this and already a dependency. Signed-off-by: Sebastiaan van Stijn <[email protected]>
The client was only using the Actions consts, but the trust package also has a dependency on notary. Remove the import to prevent Notary becoming a dependency for uses of the cli code. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This method was a shallow wrapper around trust.GetNotaryRepository, but due to its signature resulted in the trust package, and notary dependencies to become a dependency of the CLI. Consequence of this was that cli-plugins, which need the cli/command package, would also get notary and its dependencies as a dependency. Thie patch: - Removes the NotaryClient method from the interface - Inlines the code where needed, skipping the wrapper - Define a local interface for some tests where a dummy notary client was used. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added a commit
to thaJeztah/buildx
that referenced
this pull request
Mar 1, 2025
Testing docker/cli#5876 to remove notary dependency. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added a commit
to thaJeztah/buildx
that referenced
this pull request
Mar 1, 2025
Testing docker/cli#5876 to remove notary dependency. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This method was a shallow wrapper around manifeststore.NewStore, but due to its signature resulted in various dependencies becoming a dependency of the "command" package. Consequence of this was that cli-plugins, which need the cli/command package, would also get those dependencies. Thie patch: - Removes the ManifestStore method from the interface - Inlines the code where needed, skipping the wrapper - Define a local interface for some tests where a dummy store was used. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This method was a shallow wrapper around registryclient.NewRegistryClient but due to its signature resulted in various dependencies becoming a dependency of the "command" package. Consequence of this was that cli-plugins, which need the cli/command package, would also get those dependencies. Thie patch: - Removes the RegistryClient method from the interface - Inlines the code where needed, skipping the wrapper - Define a local interface for some tests where a dummy store was used. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added a commit
to thaJeztah/buildx
that referenced
this pull request
Mar 1, 2025
Testing docker/cli#5876 to remove notary dependency. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added a commit
to thaJeztah/buildx
that referenced
this pull request
Mar 1, 2025
Testing docker/cli#5876 to remove notary dependency. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli/command: remove dependency on distribution/uuid
This uuid package was introduced in 89db01e,
but we want to reduce dependency on the old docker/distribution module.
Replace it with google/uuid, which is a commonly used module for this
and already a dependency.
cli/registry/client: remove dependency on trust / notary
The client was only using the Actions consts, but the trust package
also has a dependency on notary. Remove the import to prevent Notary
becoming a dependency for uses of the cli code.
cli/command: remove NotaryClient from CLI interface
This method was a shallow wrapper around trust.GetNotaryRepository, but
due to its signature resulted in the trust package, and notary dependencies
to become a dependency of the CLI. Consequence of this was that cli-plugins,
which need the cli/command package, would also get notary and its
dependencies as a dependency.
Thie patch:
cli/command: remove ManifestStore from CLI interface
This method was a shallow wrapper around manifeststore.NewStore, but
due to its signature resulted in various dependencies becoming a dependency
of the "command" package. Consequence of this was that cli-plugins, which
need the cli/command package, would also get those dependencies.
Thie patch:
cli/command: remove RegistryClient from CLI interface
This method was a shallow wrapper around registryclient.NewRegistryClient but
due to its signature resulted in various dependencies becoming a dependency
of the "command" package. Consequence of this was that cli-plugins, which
need the cli/command package, would also get those dependencies.
Thie patch:
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)