Fix pull --parallel and --no-parallel deprecation warnings missing #12555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Proske <[email protected]>
ndeloof
approved these changes
Feb 20, 2025
thaJeztah
reviewed
Feb 20, 2025
| @@ -64,7 +67,7 @@ func pullCommand(p *ProjectOptions, dockerCli command.Cli, backend api.Service) | |||
| cmd.Flags().BoolVar(&opts.includeDeps, "include-deps", false, "Also pull services declared as dependencies") | |||
| cmd.Flags().BoolVar(&opts.parallel, "parallel", true, "DEPRECATED pull multiple images in parallel") | |||
| flags.MarkHidden("parallel") //nolint:errcheck | |||
| cmd.Flags().BoolVar(&opts.parallel, "no-parallel", true, "DEPRECATED disable parallel pulling") | |||
| cmd.Flags().BoolVar(&opts.noParallel, "no-parallel", true, "DEPRECATED disable parallel pulling") | |||
There was a problem hiding this comment.
If it's attached to "no parallel", should the default be reversed to false @ndeloof ?
glours
approved these changes
Feb 20, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Feb 26, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | patch | `v2.33.0` -> `v2.33.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.33.1`](https://github.com/docker/compose/releases/tag/v2.33.1) [Compare Source](docker/compose@v2.33.0...v2.33.1) #### What's Changed ##### ✨ Improvements - Add support for gw_priority, enable_ipv4 (requires docker v28.0) by [@​thaJeztah](https://github.com/thaJeztah) in docker/compose#12570 ##### 🐛 Fixes - Run watch standalone if menu fails to start by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12536 - Report error using non-file secret|config with read-only service by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12531 - Don't display bake suggestion when using --progress with quiet or json option by [@​glours](https://github.com/glours) in docker/compose#12561 - Fix pull --parallel and --no-parallel deprecation warnings missing by [@​maxproske](https://github.com/maxproske) in docker/compose#12555 - Fix error message when detach is implied by wait by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12566 ##### ⚙️ Dependencies - build(deps): bump github.com/spf13/cobra from 1.8.1 to 1.9.1 by [@​dependabot](https://github.com/dependabot) in docker/compose#12556 - build(deps): bump google.golang.org/grpc from 1.68.1 to 1.70.0 by [@​dependabot](https://github.com/dependabot) in docker/compose#12494 - go.mod: update to docker v28.0.0 by [@​thaJeztah](https://github.com/thaJeztah) in docker/compose#12545 **Full Changelog**: docker/compose@v2.33.0...v2.33.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODAuMiIsInVwZGF0ZWRJblZlciI6IjM5LjE4MC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I believe
--no-parallelwas mistakenly bound toopts.paralleland as a result, the deprecation warning in the PreRunE hook was never printed. Fixed the binding, and added a matching deprecation warning for--parallel.Before (No deprecation warnings in stderr):
After: