Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picker Web Fix(P-1007) #20

Merged
merged 7 commits into from
Jun 24, 2020
Merged

Picker Web Fix(P-1007) #20

merged 7 commits into from
Jun 24, 2020

Conversation

SebastianKurp
Copy link
Contributor

@SebastianKurp SebastianKurp commented Jun 19, 2020 •
edited
Loading

Linear Task:
https://linear.app/draftbit/issue/P-1007/jigsaw-fix-picker-on-web
What I did:

  • reworked our current PickerComponent.web.js to perform better.
  • I wanted to use the react-native-community picker but there is an iOS bug related to the react-native team not fully deprecating the picker component that causes issues in managed work flows with expo 37. See issue here

Screenshots:
Web:
image
Android:
image
iOS:(Got to love iOS being extra...)
image

@SebastianKurp SebastianKurp marked this pull request as ready for review June 19, 2020 20:09
@peterpme peterpme merged commit a6dae2d into master Jun 24, 2020
@peterpme peterpme deleted the @SebastianKurp/PickerWebFix branch June 24, 2020 17:36
peterpme added a commit that referenced this pull request Jul 24, 2020
@peterpme
Merge pull request #20 from draftbit/@SebastianKurp/PickerWebFix
4a2eef1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SebastianKurp @peterpme