Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 12 set with Bind Closures without Abstract rule #304

Merged
merged 7 commits into from
Feb 28, 2025

Conversation

peterfox
Copy link
Collaborator

@peterfox peterfox commented Feb 19, 2025

Changes

  • Adds the Laravel 12 set
  • Adds a ContainerBindConcreteWithClosureOnlyRector rule
  • Adds sets for the rule

Why

Handles upgrades for this PR in Laravel laravel/framework#54628

-$this->app->bind(SomeInterface::class, function () {
+$this->app->bind(function (): SomeInterface {
    return new SomeClass();
});

@peterfox peterfox self-assigned this Feb 19, 2025
@peterfox peterfox marked this pull request as draft February 19, 2025 17:07
@peterfox peterfox force-pushed the feature/laravel-12-bind-closures branch from ae5b6d7 to 3630617 Compare February 19, 2025 17:12
@peterfox peterfox marked this pull request as ready for review February 20, 2025 20:50
@GeniJaho GeniJaho merged commit 9a43971 into main Feb 28, 2025
5 checks passed
@GeniJaho GeniJaho deleted the feature/laravel-12-bind-closures branch February 28, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants