Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-selection: Link sharing #5710

Open
wants to merge 4 commits into
base: feature/ondrej/tab-multi-selection-select-mode
Choose a base branch
from

Conversation

0nko
Copy link
Member

@0nko 0nko commented Feb 27, 2025

Task/Issue URL: https://app.asana.com/0/72649045549333/1209118961868651

Description

This PR adds the tab sharing for selected tabs in the tab switcher.

Steps to test this PR

Single tab

  • Go to tab switcher
  • Tap on the More menu button
  • Tap on the Share link
  • Verify a link-sharing bottom sheet appears with the active tab URL & title
  • Tap on the More menu button
  • Tap on Select tabs to trigger selection mode
  • Select a single tab
  • Tap on the Share toolbar button
  • Verify a link-sharing bottom sheet appears with the selected tab URL & title
  • Dismiss the bottom sheet
  • Tap on the More menu button
  • Tap on the Share link
  • Verify a link-sharing bottom sheet appears with the selected tab URL & title

Multiple tabs

  • Go to tab switcher
  • Tap on the More menu button
  • Tap on Select tabs to trigger selection mode
  • Select more than 1 tab
  • Tap on the Share toolbar button
  • Verify a text-sharing bottom sheet appears with a numbered list of selected tabs' URLs

Copy link
Member Author

0nko commented Feb 27, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@0nko 0nko mentioned this pull request Feb 27, 2025
7 tasks
@0nko 0nko changed the title Revert "Reverse unrelated code" Multi-selection: Link sharing Feb 27, 2025
@0nko 0nko requested a review from mikescamell February 27, 2025 17:27
@0nko 0nko marked this pull request as ready for review February 27, 2025 17:27
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-select-mode branch from ce975ab to c71a9c5 Compare February 28, 2025 17:43
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-link-sharing branch from 47361ff to 353ba9a Compare February 28, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant