Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Bookmarks screen UI issues #5717

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

0nko
Copy link
Member

@0nko 0nko commented Mar 1, 2025

Task/Issue URL: https://app.asana.com/0/414730916066338/1209489657638562

Description

This PR fixes 2 bookmarks screen UI issues:

  • display of long bookmark folder titles in the toolbar
  • incorrect more menu button alignment for folders in the bookmark list

Steps to test this PR

Title

  • Make sure you have some existing bookmarks
  • Go to the bookmarks screen
  • Add a new bookmark folder with a long name, such as "This is a very long bookmark folder name"
  • Tap on the bookmark
  • Verify the toolbar title text is on a single line and wrapped

List

  • Make sure you have some existing bookmarks
  • Go to the bookmarks screen
  • Add a new bookmark folder
  • Verify the more menu button at the end of the folder item is aligned with the rest of the bookmarks

UI changes

Title

Before After
image image

List

Before After
image image

@0nko 0nko requested a review from joshliebe March 1, 2025 07:58
@0nko 0nko requested a review from malmstein as a code owner March 1, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant