Share transport among reverse proxies #330
Draft
+16
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0div
approved these changes
Feb 25, 2025
| } | ||
|
|
||
| // Set the transport | ||
| proxy.Transport = transport |
There was a problem hiding this comment.
unless you need those specific transport configs have you tried Director to only modify the Request? I'm curious to know if it's more efficient. Probably not if we're gonna modify the request url each time.
There was a problem hiding this comment.
I think you are right, we will need only probably need only one ReverseProxy
|
I have few more optimizations, but it isn't urgent now, postponing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables reusing connections and also lowers memory footprint