Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Fix package download URL #522

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Conversation

SlothOfAnarchy
Copy link
Contributor

The old URL yields a 404. This should work for both Debian and Red Hat.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@Crazybus
Copy link
Contributor

jenkins test this please

@Crazybus
Copy link
Contributor

Your git configuration seems to have broken our CI setup :). It seems that you don't have an email address set in your git configuration.

10:39:12 author Michel Weitbrecht <[email protected]> 1545944085 +0100
10:39:12 committer Michel Weitbrecht <> 1545946401 +0100

Are you using a special git tool for your committing or just the normal cli?

Could you also check what the output of git config --get user.email is?

@Crazybus
Copy link
Contributor

image

Also shows that GitHub is a bit confused too.

The old URL yields a 404. ES_PATH_CONF is also needed when installing
elasticsearch using the downloaded package.
@SlothOfAnarchy
Copy link
Contributor Author

Your git configuration seems to have broken our CI setup :). It seems that you don't have an email address set in your git configuration.

10:39:12 author Michel Weitbrecht <[email protected]> 1545944085 +0100
10:39:12 committer Michel Weitbrecht <> 1545946401 +0100

Are you using a special git tool for your committing or just the normal cli?

Could you also check what the output of git config --get user.email is?

The email config was indeed empty. I think the problem was that I first created the commit using the GitHub web editor and later cloned it locally to amend the environment variable.
I set the email and force-pushed again, now it should be fixed.

@Crazybus
Copy link
Contributor

Thanks!

jenkins test this please

Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for picking this one up!

@Crazybus Crazybus merged commit 4623f56 into elastic:master Jan 3, 2019
@SlothOfAnarchy SlothOfAnarchy deleted the patch-1 branch January 3, 2019 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants