Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Migrate docs from AsciiDoc to Markdown #2221

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

colleenmcginnis
Copy link
Contributor

Migrate docs from AsciiDoc to Markdown. The preview can be built after #2220 is merged.

@colleenmcginnis colleenmcginnis added the Team:Docs Label for the Observability docs team label Feb 26, 2025
@xrmx
Copy link
Member

xrmx commented Mar 3, 2025

run docs-build

@colleenmcginnis
Copy link
Contributor Author

@xrmx can you please review when you have a chance (preview)?

Copy link
Member

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't gone through all but there a few things broken


## Step 1: Select the AWS Region and Architecture [_step_1_select_the_aws_region_and_architecture]

<style>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rendering of this is broken

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a closer look at this today.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elastic/docs-builder does not support CSS and JavaScript in Markdown, and there is no plan to support it in the future. I made some updates in e795df5. Take a look at the preview and let me know what you think about this approach.

@@ -0,0 +1,5 @@
toc:
- file: index.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong with rendering

Schermata del 2025-03-04 17-11-02

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is expected for now. It will be resolved when we're able to bundle pages from all repos together. elastic/docs-builder#621

Co-authored-by: Riccardo Magliocchetti <[email protected]>
@xrmx
Copy link
Member

xrmx commented Mar 11, 2025

@colleenmcginnis What's the plan with the Pr after I approve? Do you plan to wait on the known issues to be resolved or not? I'm fine with rendering having issues but I'm worried to find other links that changed destination like the observability apm one.

@colleenmcginnis
Copy link
Contributor Author

What's the plan with the Pr after I approve?

Not much will happen immediately. After this is merged, you'll continue to be able to see the preview at https://docs-v3-preview.elastic.dev/elastic/apm-agent-python/tree/main/reference/ (that link won't work until these files are on main). You'll also be able to start making edits directly to the Markdown files for new releases, etc.

In the next week or so we'll have the docs assembler ready to go, which will allow us to build these docs as a part of the larger Elastic docs. This will fix issues like elastic/docs-builder#621, and will allow you to see how APM Python agent docs fit into the larger information architecture.

Then, these docs will go live along with the Elastic Stack v9.0 release, and they will replace the current docs on elastic.co (the URLs will likely change, but we'll implement redirects for every current page). Previous versions will continue to be published using the AsciiDoc system, and the URLs will stay the same.

Do you plan to wait on the known issues to be resolved or not?

We don't have to wait on any known issues that are going to be fixed in docs-builder (like #2221 (comment)). If there are content-related problems, we should either (1) fix them before merging this PR or (2) open an issue to track any outstanding tasks so we can address them before the 9.0 release (example).

I'm fine with rendering having issues but I'm worried to find other links that changed destination like the observability apm one.

I can do a pass looking closely at each link later today.

@xrmx
Copy link
Member

xrmx commented Mar 11, 2025

What's the plan with the Pr after I approve?

Not much will happen immediately. After this is merged, you'll continue to be able to see the preview at https://docs-v3-preview.elastic.dev/elastic/apm-agent-python/tree/main/reference/ (that link won't work until these files are on main). You'll also be able to start making edits directly to the Markdown files for new releases, etc.

In the next week or so we'll have the docs assembler ready to go, which will allow us to build these docs as a part of the larger Elastic docs. This will fix issues like elastic/docs-builder#621, and will allow you to see how APM Python agent docs fit into the larger information architecture.

Then, these docs will go live along with the Elastic Stack v9.0 release, and they will replace the current docs on elastic.co (the URLs will likely change, but we'll implement redirects for every current page). Previous versions will continue to be published using the AsciiDoc system, and the URLs will stay the same.

Yeah but at the moment everything we have in main is moved to the release branch, if this goes in that is not true anymore and I have to cherry-pick everything but the docs. So I would prefer to delay the merge as much as I can.

Do you plan to wait on the known issues to be resolved or not?

We don't have to wait on any known issues that are going to be fixed in docs-builder (like #2221 (comment)). If there are content-related problems, we should either (1) fix them before merging this PR or (2) open an issue to track any outstanding tasks so we can address them before the 9.0 release (example).

I'm fine with rendering having issues but I'm worried to find other links that changed destination like the observability apm one.

I can do a pass looking closely at each link later today.

That would be great, thanks!

@colleenmcginnis
Copy link
Contributor Author

I can do a pass looking closely at each link later today.

That would be great, thanks!

I pushed a commit cleaning up some links (and other things) after looking at AsciiDoc and Markdown pages side by side.

Note: There are a couple links to new Markdown docs in other repos (like elastic/beats and elastic/ecs) that don't work yet because the equivalent of this PR in those repos also has not been merged into main yet. The build will error if those links don't work after the PRs have been merged in those repos (so we should be safe to merge here whenever).

Yeah but at the moment everything we have in main is moved to the release branch, if this goes in that is not true anymore and I have to cherry-pick everything but the docs. So I would prefer to delay the merge as much as I can.

Thanks for bringing this up. I chatted with @bmorelli25 about this today. We discussed implementing a solution similar to what we did for repos that did not have versioned docs (i.e. main === current) that might make the transition from AsciiDoc to Markdown a little less painful for the APM agent teams: elastic/docs#3185. With this solution, you'd be able to force push docs updates to 6.x without interrupting the AsciiDoc build while we wait for these docs to go live with the 9.0 release.

Take a look and let me know if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-python Team:Docs Label for the Observability docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants