Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make server certificate verification mandatory in fips mode #2227

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

xrmx
Copy link
Member

@xrmx xrmx commented Mar 3, 2025

What does this pull request do?

Block disabling server certificate validation via ELASTIC_APM_VERIFY_SERVER_CERT in fips mode

This requires to add validation support to _BoolConfigValue

Related issues

Closes #2228

@xrmx xrmx force-pushed the dont-disable-verify-cert-on-fips branch from 49ac315 to b21b942 Compare March 3, 2025 15:50
@xrmx xrmx marked this pull request as ready for review March 3, 2025 15:57
@xrmx xrmx requested a review from basepi March 3, 2025 16:01
@xrmx xrmx changed the title Dont disable verify cert on fips Make server certificate verification mandatory in fips mode Mar 3, 2025
@xrmx xrmx merged commit 6004832 into elastic:main Mar 10, 2025
120 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it impossible to disable server cert verify in fips mode
2 participants