-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fill in ECS-compat top-level fields from context #1766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebasing master should fix the test
* agent <- context.service.agent * host <- context.system * process <- context.process * process.args <- context.process.argv, now indexed * service <- context.service Also indexes observer.listening, missed previously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will moving context.requrest.url.*
-> url.*
and context.response.*
-> http.response.*
be handled in an extra PR?
I can take a look at the skipped test (rebasing onto master did not solve it).
Hmm, i thought it was because of the onboarding document ordering |
It is because the metadata are moved out of |
15ccca2
to
8c8b231
Compare
@graphaelli I did a |
originally moved from system.platform
Thanks for the fixups. All review feedback has been addressed and one test has been skipped, @simitt is already working on that one, thank you. |
only the sync job failed, as expected. |
Also indexes observer.listening, missed previously.