Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fill in ECS-compat top-level fields from context #1766

Merged
merged 12 commits into from
Jan 11, 2019

Conversation

graphaelli
Copy link
Member

@graphaelli graphaelli commented Jan 11, 2019

  • agent <- context.service.agent
  • host <- context.system
    • host.os.platform <- context.system.platform
  • process <- context.process
    • process.args <- context.process.argv, now indexed
  • service <- context.service

Also indexes observer.listening, missed previously.

Copy link
Contributor

@jalvz jalvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebasing master should fix the test

* agent <- context.service.agent
* host <- context.system
* process <- context.process
  * process.args <- context.process.argv, now indexed
* service <- context.service

Also indexes observer.listening, missed previously.
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will moving context.requrest.url.* -> url.* and context.response.* -> http.response.* be handled in an extra PR?

I can take a look at the skipped test (rebasing onto master did not solve it).

@jalvz
Copy link
Contributor

jalvz commented Jan 11, 2019

Hmm, i thought it was because of the onboarding document ordering

@simitt
Copy link
Contributor

simitt commented Jan 11, 2019

It is because the metadata are moved out of context, so the test needs to be adapted. I am on it.

@simitt
Copy link
Contributor

simitt commented Jan 11, 2019

@graphaelli I did a force-push because I rebased to master.

@graphaelli
Copy link
Member Author

Thanks for the fixups. All review feedback has been addressed and one test has been skipped, @simitt is already working on that one, thank you.

@graphaelli
Copy link
Member Author

only the sync job failed, as expected.

@graphaelli graphaelli merged commit a992424 into elastic:master Jan 11, 2019
@graphaelli graphaelli deleted the ecs-move-context branch January 11, 2019 16:04
graphaelli added a commit to graphaelli/apm-integration-testing that referenced this pull request Jan 11, 2019
graphaelli added a commit to graphaelli/apm-integration-testing that referenced this pull request Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants