Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCUSS] Should we require that source/destination always be populated, even if client/server are populated? #246

Closed
webmat opened this issue Dec 6, 2018 · 5 comments
Assignees
Labels

Comments

@webmat
Copy link
Contributor

webmat commented Dec 6, 2018

#236 introduces client/server as the other pair of network endpoints we can use to represent an exchange over the network. We've discussed in #61 that there can be big advantages to representing the exchange that way, over using the source/destination pair.

I think it's great to populate client/server when we can, but I would contend that when this happens, we should still populate source/destination.

I want to know that 100% of my events have source/destination. (And I think we can populate it in all situations.)

What do people think? Should we introduce this?

@webmat
Copy link
Contributor Author

webmat commented Dec 6, 2018

@farrp
Copy link

farrp commented Dec 6, 2018 via email

@strikaco
Copy link

strikaco commented Dec 6, 2018

Yes. Most network appliances and analytics tools already think in terms of source/dest. It would make sense for a common schema to enforce adherence to terms applicable to the broadest base-- the users of everything from Wireshark to Splunk and many network appliances are already familiar with these terms.

Adding an additional pair of terms for the same artifacts and making either set optional opens the door to ambiguity, the consequences of which have been one of our biggest headaches with the Elastic platform and one I personally hoped to see resolved with the advent of ECS. Our current schema already requires us having to check multiple fieldsets for the same artifact (usually under incident!) and it's an error-prone waste of everybody's time. Field aliases are only a partial (and recent) solution; I would hate to see this anti-pattern end up in any standard or guideline.

The client/server designation seems rather arbitrary and niche...if there's a logical source/dest to be found in the document, being artifacts common to all network events they ought to always be made available under those terms.

@ruflin ruflin removed the 1.0.0-beta2 label Dec 7, 2018
@ruflin
Copy link
Contributor

ruflin commented Dec 7, 2018

No strong opinions here. I removed the beta2 label as this will be a documentation change and not a change in fields, so it can follow later.

@webmat
Copy link
Contributor Author

webmat commented Dec 10, 2018

Submitted a PR for this: #265. The wording is very much open to discussion :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants