Add Top Level Client and Server Objects #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikePaquette
force-pushed
the
client-server-add
branch
from
290d87f to
8ff3ef5
Compare
webmat
suggested changes
Dec 5, 2018
There was a problem hiding this comment.
This looks good.
A few points, though:
- I think this PR should add
clientandserverto the list of placesgeois expected to be nested. - I think this PR should add
clientandserverto the list of placesuseris expected to be nested. - I also think it would be helpful if the definitions the the connection endpoints mentioned their expected pair explicitly: client & server are meant to be used together, and source & destination are meant to be used together.
|
If #179 is merged then I think we want to add the |
webmat
pushed a commit
to webmat/ecs
that referenced
this pull request
Dec 6, 2018
Just like client and server (elastic#236).
MikePaquette
force-pushed
the
client-server-add
branch
from
d342200 to
a199c48
Compare
ruflin
approved these changes
Dec 7, 2018
MikePaquette
force-pushed
the
client-server-add
branch
from
d4fa25b to
da793f1
Compare
webmat
added a commit
that referenced
this pull request
Dec 7, 2018
Just like client and server (#236).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #63 by adding the
client.*andserver.*top level objects to contain fields used in connection/session level events.Many thanks to those who expended time, energy, and passion in issue #63 along the way!