Add file.fork_name to ECS #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebeahan
reviewed
Mar 4, 2021
|
@rw-access Is this addition still something you want to move forward on? |
Co-authored-by: Eric Beahan <[email protected]>
Co-authored-by: Eric Beahan <[email protected]>
|
Revived the PR and moving from draft to ready for review |
ebeahan
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
One note about the changelog entry, but otherwise LGTM!
I merged #1509 this morning which changed the version in the master branch, and it's the cause of the merge conflicts.
Pulling in those changes and re-running make should clear it up.
ebeahan
pushed a commit
to ebeahan/ecs
that referenced
this pull request
Jul 13, 2021
* Add file.fork_name * Add generated code * Add comma Co-authored-by: Eric Beahan <[email protected]> * Add note to NTFS Co-authored-by: Eric Beahan <[email protected]> * Update CHANGELOG.next.md * Fix comma * Re-run make generate * make experimental * Rearrange changelog entry Co-authored-by: Eric Beahan <[email protected]> # Conflicts: # experimental/generated/csv/fields.csv # generated/csv/fields.csv
ebeahan
added a commit
that referenced
this pull request
Jul 13, 2021
* Add file.fork_name * Add generated code * Add comma Co-authored-by: Eric Beahan <[email protected]> * Add note to NTFS Co-authored-by: Eric Beahan <[email protected]> * Update CHANGELOG.next.md * Fix comma * Re-run make generate * make experimental * Rearrange changelog entry Co-authored-by: Ross Wolf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1285
Added
file.fork_nameto ECS.