-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Extend Threat Fieldset - Stage 0 Proposal #1300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for stage 0 👍
Co-authored-by: Eric Beahan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, for the sake of posterity (and perhaps an eye on the horizon) someday we may want to update the Threat RFC's ATT&CK commentary to reflect ATT&CK-defined elements vs calling them ATT&CK elements (ex: ATT&CK-defined software vs ATT&CK software). It's a very minor point, and one which is unlikely to confuse the user, so no change recommended or required.
Thanks, all! I'll set the advance date, RFC #, and merge it! 🚢 |
make test
? Yesmake
and committed those changes? YesPreview of the markdown proposal