Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Extend Threat Fieldset - Stage 0 Proposal #1300

Merged
merged 8 commits into from
Mar 29, 2021
Merged

Conversation

peasead
Copy link
Contributor

@peasead peasead commented Mar 15, 2021

  • Have you signed the contributor license agreement? Yes
  • Have you followed the contributor guidelines? Yes
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? Yes
  • If submitting code/script changes, have you verified all tests pass locally using make test? Yes
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? Yes
  • Is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed. Yes
  • Have you added an entry to the CHANGELOG.next.md? Yes

Preview of the markdown proposal

@peasead peasead added the RFC label Mar 15, 2021
@peasead peasead self-assigned this Mar 15, 2021
@peasead peasead requested review from ebeahan and removed request for ebeahan March 15, 2021 20:38
ebeahan
ebeahan previously approved these changes Mar 17, 2021
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for stage 0 👍

Co-authored-by: Eric Beahan <[email protected]>
ebeahan
ebeahan previously approved these changes Mar 17, 2021
@ebeahan ebeahan requested a review from devonakerr March 17, 2021 21:45
devonakerr
devonakerr previously approved these changes Mar 29, 2021
Copy link

@devonakerr devonakerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, for the sake of posterity (and perhaps an eye on the horizon) someday we may want to update the Threat RFC's ATT&CK commentary to reflect ATT&CK-defined elements vs calling them ATT&CK elements (ex: ATT&CK-defined software vs ATT&CK software). It's a very minor point, and one which is unlikely to confuse the user, so no change recommended or required.

@ebeahan
Copy link
Member

ebeahan commented Mar 29, 2021

Thanks, all! I'll set the advance date, RFC #, and merge it! 🚢

@ebeahan ebeahan merged commit dee2c7e into master Mar 29, 2021
@peasead peasead deleted the extend-threat-stage-0 branch March 31, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants