Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra newline from Go code generator #1350

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Apr 12, 2021

Changes introduced in #1254 added an extraneous newline character to each .go file generated by make gocodegen.

This change removes the extra newline and fixes the test failures due to the modified, uncommitted changes in code/go/ecs.

@ebeahan ebeahan added bug Something isn't working needs_backport 1.x 1.10.0 labels Apr 12, 2021
@ebeahan ebeahan self-assigned this Apr 12, 2021
@ebeahan ebeahan requested review from kgeller and djptek April 12, 2021 22:25
@ebeahan ebeahan merged commit eab1d5f into elastic:master Apr 13, 2021
ebeahan added a commit to ebeahan/ecs that referenced this pull request Apr 13, 2021
@ebeahan ebeahan deleted the bug/handle-gocodegen-newline branch April 13, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.10.0 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants