Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom descriptions for self-nesting reuses #1366

Merged
merged 13 commits into from
Apr 20, 2021
Merged

Allow custom descriptions for self-nesting reuses #1366

merged 13 commits into from
Apr 20, 2021

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Apr 19, 2021 •
edited
Loading

This adds the ability to override a short description when self nesting fields. Also, a small tweak to the ascii docs tables, for a third column to capture the field being nested.

@kgeller kgeller requested review from ebeahan and djptek April 19, 2021 15:08
ebeahan
ebeahan reviewed Apr 19, 2021
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of notes, but overall the changes look great, @kgeller!

In addition to process.parent.*, I'm looking forward to using these changes in some other places. We can handle those in a separate PR, though 😄 .

@kgeller kgeller requested a review from ebeahan April 20, 2021 18:19
ebeahan
ebeahan reviewed Apr 20, 2021
View reviewed changes
@kgeller kgeller requested a review from ebeahan April 20, 2021 19:25
ebeahan
ebeahan approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I see some other cases of text wrapping even after switching the header to Field Set, but I don't think we should hold off on introducing these changes. We can iterate on it in another PR.

Screen Shot 2021-04-20 at 2 57 33 PM

@kgeller kgeller added the 1.x label Apr 20, 2021
@kgeller kgeller merged commit 963f948 into elastic:master Apr 20, 2021
@kgeller kgeller mentioned this pull request Apr 20, 2021
Merged
kgeller added a commit that referenced this pull request Apr 20, 2021
@kgeller
Allow custom descriptions for self-nesting reuses (#1366) (#1369)
f4998af 
Allow custom descriptions for self-nesting reuses
@kgeller kgeller deleted the custom-descriptions-for-self-nesting branch April 20, 2021 20:18
@ebeahan ebeahan added the 1.10.0 label Apr 20, 2021
@kgeller kgeller linked an issue May 3, 2021 that may be closed by this pull request
Allow custom descriptions for self-nesting reuses #1174
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebeahan ebeahan ebeahan approved these changes

@djptek djptek Awaiting requested review from djptek

Assignees
No one assigned
Labels
1.x 1.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow custom descriptions for self-nesting reuses
2 participants
@kgeller @ebeahan