Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide updated descriptions for user.* field reuses #1382

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Apr 23, 2021

Using the short_override field, update the field reuse descriptions for these three users.* reuses:

  • user.changes.*
  • user.effective.*
  • user.target.*

These updated descriptions will better describe the use of each.

@ebeahan ebeahan self-assigned this Apr 23, 2021
@ebeahan ebeahan changed the title provide better short descriptions for user field reuses Provide updated descriptions for user.* field reuses Apr 23, 2021
@ebeahan ebeahan requested review from kgeller and djptek April 23, 2021 19:01
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see some usages of this! LGTM

@ebeahan ebeahan merged commit d66dc89 into elastic:master Apr 23, 2021
@ebeahan ebeahan deleted the update-user-reuse-descriptions branch April 23, 2021 20:50
ebeahan added a commit to ebeahan/ecs that referenced this pull request Apr 23, 2021
* provide better short descriptions for user field reuses

* changelog
ebeahan added a commit to ebeahan/ecs that referenced this pull request Apr 23, 2021
* provide better short descriptions for user field reuses

* changelog
ebeahan added a commit that referenced this pull request Apr 23, 2021
* provide better short descriptions for user field reuses

* changelog
ebeahan added a commit that referenced this pull request Apr 23, 2021
* provide better short descriptions for user field reuses

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants