Add agent.type field and redefine agent.name #150
Conversation
|
@roncohen @graphaelli Would be good to get your take on this one from an APM view. |
ruflin
changed the title
ruflin
force-pushed
the
agent-type
branch
3 times, most recently
from
6d704e6 to
b3ad81e
Compare
There was a problem hiding this comment.
I like this emerging concept of dual fields, that allows for a custom name and a standardized name.
I wonder if name + type is the right pair of field names, however. I do think name is fine. And type is also growing on me.
Should we review the following usages of the word type elsewhere, however?
device.type: this is currently meant to contain a generic term like 'firewall', not a standardized (but specific) name.host.type&cloud.machine.type: meant to convey a host model or virtual instance type. No concept of a host's standardized name or purpose (e.g.mysql).event.type: general event classification
This is an overview of the other uses of type. I'm not saying we have to change them, I'm just surfacing a nagging worry I have, about using the word type to mean something very specific in some cases (name+type) and something else in the above cases.
|
Let's not block this PR by the above follow up discussion. I would even suggest to not touch the other type fields for now and reevaluate in a few months if we hit issues. |
This is also inspired by the discussion in #142