Support multi-field type fallback #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgeller
approved these changes
Jul 21, 2021
ebeahan
added a commit
to ebeahan/ecs
that referenced
this pull request
Jul 21, 2021
* support multi-field fallback * add match_only_text fallback * add tests for match_only_text multi-field support * comments for posterity * CHANGELOG.next entry # Conflicts: # scripts/generators/es_template.py
ebeahan
added a commit
that referenced
this pull request
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ES 6 type fallback will also apply to multi-field field definition sections in generated Elasticsearch 6.x templates.
I also added the
match_only_textfallback in this PR to allow the added multi-field fallback tests to pass.Closes #1526, #1527