Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding service.address #1537

Merged
merged 11 commits into from
Jul 28, 2021
Merged

Adding service.address #1537

merged 11 commits into from
Jul 28, 2021

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Jul 27, 2021

@kgeller kgeller marked this pull request as ready for review July 27, 2021 15:13
@kgeller kgeller requested review from mtojek and ebeahan July 27, 2021 15:14
andrewkroh
andrewkroh reviewed Jul 27, 2021
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the definition would benefit from some additional clarification.

@mtojek mtojek requested a review from jsoriano July 27, 2021 15:56
andrewkroh
andrewkroh reviewed Jul 27, 2021
View reviewed changes
mtojek
mtojek approved these changes Jul 27, 2021
View reviewed changes
Copy link

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ebeahan
ebeahan reviewed Jul 27, 2021
View reviewed changes
CHANGELOG.next.md
@@ -9,6 +9,11 @@ Thanks, you're awesome :-) -->
## Unreleased

### Schema Changes

#### Added
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't noticed this section header was missing, and I've been putting my schema changes under Tooling! 😅

Thanks for catching it! We'll make sure the other sections are cleaned up.

ebeahan
ebeahan approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

jsoriano
jsoriano approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@kgeller kgeller merged commit f91dda1 into elastic:master Jul 28, 2021
@kgeller kgeller deleted the add-service-address-field branch July 28, 2021 13:32
@kgeller kgeller mentioned this pull request Jul 28, 2021
Merged
kgeller added a commit that referenced this pull request Jul 28, 2021
@kgeller
Adding service.address (#1537) (#1538)
c601c1e
@jsoriano jsoriano mentioned this pull request Aug 30, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

@ebeahan ebeahan ebeahan approved these changes

@mtojek mtojek mtojek approved these changes

Assignees
No one assigned
Labels
1.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kgeller @jsoriano @andrewkroh @ebeahan @mtojek