Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy trailing spaces and newlines #1667

Merged
merged 13 commits into from
Nov 18, 2021
Merged

Tidy trailing spaces and newlines #1667

merged 13 commits into from
Nov 18, 2021

Conversation

djptek
Copy link
Contributor

@djptek djptek commented Nov 17, 2021

  • Have you signed the contributor license agreement? Y
  • Have you followed the contributor guidelines? Y
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? Y
  • If submitting code/script changes, have you verified all tests pass locally using make test? Y
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? Y
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. Y
  • Have you added an entry to the CHANGELOG.next.md? Y

@@ -441,15 +441,15 @@
in the cloud, the field contains cloud data from the machine the service is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot there were some fields with a footnote attribute!

I think this is good detail we should capture somehow in the documentation in addition to the schema.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebeahan I hadn't noticed that - does footnote still add value or could we add an RFC to merge existing footnotes into description? From what I've seen they are mostly usage examples

Co-authored-by: Eric Beahan <[email protected]>
@djptek djptek merged commit e510ecf into elastic:main Nov 18, 2021
@djptek djptek deleted the tidy_trailing_spaces_and_newlines branch November 18, 2021 10:26
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Nov 19, 2021
* Tidy training spaces and newlines
Co-authored-by: Eric Beahan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants