Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up to #81 on network layers #170

Merged
merged 3 commits into from
Nov 6, 2018
Merged

Follow-up to #81 on network layers #170

merged 3 commits into from
Nov 6, 2018

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Nov 5, 2018 •
edited
Loading

  • Make the capitalization of IPv consistent
  • Missing changelog
  • Tweak the wording of the examples

This is a quick follow-up to #81

@webmat webmat requested review from ruflin and robgil November 5, 2018 21:59
robgil
robgil approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@robgil robgil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning up the wording. Much more succinct. :)

@webmat webmat self-assigned this Nov 6, 2018
@webmat webmat merged commit 04f76be into elastic:master Nov 6, 2018
@webmat webmat deleted the network-layer-follow-up branch November 6, 2018 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

@robgil robgil robgil approved these changes

Assignees

@webmat webmat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@webmat @ruflin @robgil