Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Introduce an email field set - stage 3 #1704

Merged
merged 6 commits into from
Feb 23, 2022
Merged

[RFC] Introduce an email field set - stage 3 #1704

merged 6 commits into from
Feb 23, 2022

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Dec 21, 2021 •
edited
Loading

Summary

Continuing onto Stage 3 with this proposal to introduce the email.* field set to the schema.

Stage 3 (Finished) Criteria:

  • Opened pull request for this candidate revising the existing candidate
  • Included multiple real-world example source documents
  • Existing or newly raised questions and concerns are addressed
  • No objections from sponsor, ECS team, or subject matter experts

Preview of markdown proposal

@ebeahan ebeahan added the RFC label Dec 21, 2021
@ebeahan ebeahan self-assigned this Dec 21, 2021
@ebeahan ebeahan requested review from jamiehynds and a team January 5, 2022 21:24
jamiehynds
jamiehynds approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@jamiehynds jamiehynds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kgeller
kgeller approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebeahan
Copy link
Member Author

ebeahan commented Feb 16, 2022

[TTL: 7d] Final call for any changes; otherwise, will advance email fields to GA.

@ebeahan ebeahan merged commit e2b2b12 into elastic:main Feb 23, 2022
@ebeahan ebeahan deleted the rfc/0010/stage-3 branch February 23, 2022 16:35
@ebeahan ebeahan mentioned this pull request Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgeller kgeller kgeller approved these changes

@jamiehynds jamiehynds jamiehynds approved these changes

Assignees

@ebeahan ebeahan

Labels
RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebeahan @kgeller @jamiehynds