Beats: fix default_field setting for root fields #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebeahan
reviewed
Jan 5, 2022
There was a problem hiding this comment.
The generator was adding the default_field setting to non-root fieldsets, causing top-level fields (like message) to be excluded from the default_field index template configuration.
With these changes, top-level fields, like message, will now have default_field: true explicitly defined if that top-level field is in the allow list?
Yes, exactly. |
The generator was adding the default_field=true setting for non-root fieldsets, so top-level fields like `message` were missing the flag and thus not being added to the default_field index template configuration.
adriansr
force-pushed
the
fix_default_field
branch
from
1d97d31 to
11bfc2b
Compare
ebeahan
pushed a commit
to ebeahan/ecs
that referenced
this pull request
Jan 11, 2022
The generator was adding the default_field=true setting for non-root fieldsets, so top-level fields like `message` were missing the flag and thus not being added to the default_field index template configuration.
ebeahan
pushed a commit
to ebeahan/ecs
that referenced
this pull request
Jan 11, 2022
The generator was adding the default_field=true setting for non-root fieldsets, so top-level fields like `message` were missing the flag and thus not being added to the default_field index template configuration.
ebeahan
added a commit
that referenced
this pull request
Jan 12, 2022
* Beats: fix default_field setting for root fields (#1711) The generator was adding the default_field=true setting for non-root fieldsets, so top-level fields like `message` were missing the flag and thus not being added to the default_field index template configuration. * move changelog entry into 8.0 section Co-authored-by: Adrian Serrano <[email protected]>
ebeahan
added a commit
that referenced
this pull request
Jan 12, 2022
* Beats: fix default_field setting for root fields (#1711) The generator was adding the default_field=true setting for non-root fieldsets, so top-level fields like `message` were missing the flag and thus not being added to the default_field index template configuration. * move changelog entry into 8.0 section Co-authored-by: Adrian Serrano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generator was adding the
default_fieldsetting to non-root fieldsets, causing top-level fields (likemessage) to be excluded from thedefault_fieldindex template configuration.Relates elastic/beats#29633