Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Higher default compression for composable templates #1712

Merged
merged 5 commits into from
Jan 5, 2022

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Jan 5, 2022

Addresses #1339

The built-in index templates settings in Elasticsearch (logs-settings, metrics-settings, synthetics-settings) enable a higher compression ratio (DEFLATE vs LZ4) as the default now with the new indexing strategy: index.codec: best_compression

@kgeller kgeller added the 8.1.0 label Jan 5, 2022
@kgeller kgeller requested a review from a team January 5, 2022 16:17
@kgeller kgeller self-assigned this Jan 5, 2022
@kgeller kgeller linked an issue Jan 5, 2022 that may be closed by this pull request
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgeller kgeller merged commit 9b65364 into elastic:main Jan 5, 2022
@kgeller kgeller deleted the higher-default-compression branch January 5, 2022 18:24
@ebeahan
Copy link
Member

ebeahan commented Feb 22, 2022

@kgeller, I think this one still needs to be backported?

kgeller added a commit to kgeller/ecs that referenced this pull request Feb 22, 2022
# Conflicts:
#	scripts/generators/es_template.py
kgeller added a commit to kgeller/ecs that referenced this pull request Feb 22, 2022
# Conflicts:
#	CHANGELOG.next.md
#	scripts/generators/es_template.py
@kgeller
Copy link
Contributor Author

kgeller commented Feb 22, 2022

@ebeahan good catch!

Looks like they made it in already, probably from another backport, but adding them just in case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use higher compression as default in composable index template settings
2 participants