-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Higher default compression for composable templates #1712
Merged
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebeahan
approved these changes
Jan 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kgeller, I think this one still needs to be backported? |
kgeller
added a commit
to kgeller/ecs
that referenced
this pull request
Feb 22, 2022
# Conflicts: # scripts/generators/es_template.py
kgeller
added a commit
to kgeller/ecs
that referenced
this pull request
Feb 22, 2022
# Conflicts: # CHANGELOG.next.md # scripts/generators/es_template.py
@ebeahan good catch! Looks like they made it in already, probably from another backport, but adding them just in case |
kgeller
added a commit
that referenced
this pull request
Feb 23, 2022
kgeller
added a commit
that referenced
this pull request
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1339
The built-in index templates settings in Elasticsearch (logs-settings, metrics-settings, synthetics-settings) enable a higher compression ratio (DEFLATE vs LZ4) as the default now with the new indexing strategy:
index.codec: best_compression